Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awsxrayproxy: TestFactory_CreateExtension failed #5726

Closed
tigrannajaryan opened this issue Oct 13, 2021 · 5 comments · Fixed by #5746
Closed

awsxrayproxy: TestFactory_CreateExtension failed #5726

tigrannajaryan opened this issue Oct 13, 2021 · 5 comments · Fixed by #5746
Labels
bug Something isn't working closed as inactive Stale

Comments

@tigrannajaryan
Copy link
Member

Test failed here: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/5694/checks?check_run_id=3881454973

make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/awsxrayproxy'
go test -race -timeout 300s --tags="" ./...
--- FAIL: TestFactory_CreateExtension (0.00s)
    factory_test.go:71: 
        	Error Trace:	factory_test.go:71
        	Error:      	Received unexpected error:
        	            	Post "http://127.0.0.1:41973/GetSamplingRules": dial tcp 127.0.0.1:41973: connect: connection refused
        	Test:       	TestFactory_CreateExtension
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xfed37e]

goroutine 6 [running]:
testing.tRunner.func1.2({0x1094840, 0x213d380})
	/opt/hostedtoolcache/go/1.17.1/x64/src/testing/testing.go:1209 +0x36c
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.17.1/x64/src/testing/testing.go:1212 +0x3b6
panic({0x1094840, 0x213d380})
	/opt/hostedtoolcache/go/1.17.1/x64/src/runtime/panic.go:1047 +0x266
github.com/open-telemetry/opentelemetry-collector-contrib/extension/awsxrayproxy.TestFactory_CreateExtension(0x0)
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/awsxrayproxy/factory_test.go:74 +0x79e
testing.tRunner(0xc000001a00, 0x11b6ad8)
	/opt/hostedtoolcache/go/1.17.1/x64/src/testing/testing.go:1259 +0x230
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.17.1/x64/src/testing/testing.go:1306 +0x727
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/extension/awsxrayproxy	0.044s
FAIL
make[2]: *** [../../Makefile.Common:45: test] Error 1
make[2]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/awsxrayproxy'
make[1]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
make[1]: *** [Makefile:148: for-all-target-./extension/awsxrayproxy] Error 2
make: *** [Makefile:68: gotest] Error 2
Error: Process completed with exit code 2.
@tigrannajaryan tigrannajaryan added the bug Something isn't working label Oct 13, 2021
@tigrannajaryan
Copy link
Member Author

@anuraaga @Aneurysm9 @mxiamxia can you have a look as codeowners?

@tigrannajaryan tigrannajaryan changed the title TestFactory_CreateExtension failed awsxrayproxy: TestFactory_CreateExtension failed Oct 13, 2021
@tigrannajaryan
Copy link
Member Author

Happened again: #5694 (comment)

tigrannajaryan pushed a commit that referenced this issue Oct 14, 2021
- Report error if happened when starting proxy server
- Target a test HTTP server as the backend in unit test instead of AWS service

While it's hard to say if this is the problem causing flaky tests, I guess some flakiness is expected when hitting an actual cloud service backend from tests so fixed that.

Fixes #5726 (?)
@codeboten codeboten reopened this Nov 1, 2021
@codeboten
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed as inactive Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants