[chore] add generate commands to build targets for otelcontribcol and oteltestbedcol #35676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… oteltestbedcol Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
TylerHelmuth
approved these changes
Oct 8, 2024
atoulme
approved these changes
Oct 8, 2024
evan-bradley
approved these changes
Oct 8, 2024
|
Downside to removing the code from the repo is that these make targets will take longer now. I agree with this as a solution for now tho. |
| @@ -283,7 +283,7 @@ ifndef COMPONENT | |||
| endif | |||
|
|
|||
| .PHONY: docker-otelcontribcol | |||
| docker-otelcontribcol: | |||
| docker-otelcontribcol: genotelcontribcol | |||
| @@ -294,7 +294,7 @@ docker-telemetrygen: | |||
| rm cmd/telemetrygen/telemetrygen_* | |||
|
|
|||
| .PHONY: generate | |||
| generate: install-tools | |||
| generate: install-tools genotelcontribcol genoteltestbedcol | |||
| @@ -337,7 +337,7 @@ genotelcontribcol: $(BUILDER) | |||
|
|
|||
| # Build the Collector executable. | |||
| .PHONY: otelcontribcol | |||
| otelcontribcol: | |||
| otelcontribcol: genotelcontribcol | |||
There was a problem hiding this comment.
The lite version need this as well.
| * `make genotelcontribcol` | ||
| * `make genoteltestbedcol` | ||
| * `make gotidy` |
|
Sorry, I fixed all comments in a different PR. If you still need more change feel free to re-open the PR. |
|
ok 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #35631
Testing
make otelcontribcolwith a clean working directory, it should succeedmake oteltestbedcolwith a clean working directory, it should succeed