Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make otelcontribcol is now failing due to no Go files in ./cmd/otelcontribcol #35631

Closed
developer-guy opened this issue Oct 5, 2024 · 7 comments · Fixed by #35707
Closed
Assignees
Labels
bug Something isn't working

Comments

@developer-guy
Copy link

Component(s)

cmd/otelcontribcol

What happened?

I was trying to build otelcontribcol using a make target otelcontribcol but it started failing after v0.111.0 because there are no Go files anymore in .cmd/otelcontribcol, is this some sort of a bug or is there any new way of building the project?

Thanks.

Collector version

x.x.x

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@developer-guy developer-guy added bug Something isn't working needs triage New item requiring triage labels Oct 5, 2024
@BharatKJain
Copy link

BharatKJain commented Oct 7, 2024

I am facing the same issue, let me know if you find something.

[EDIT - Mon Oct 7 09:42:34 UTC 2024] The following mentioned files are removed from cmd/otelcontribcol:

components.go
go.mod
go.sum

Maybe that's why it breaking.

@BharatKJain
Copy link

Found the solution, before running make otelcontribcol, you need to run make genotelcontribcol

@developer-guy
Copy link
Author

I can confirm that it worked yeah!

@swamisriman
Copy link
Contributor

I've been banging my head since noon 🤦🏻‍♂️.
Thanks @BharatKJain !

@BharatKJain
Copy link

BharatKJain commented Oct 7, 2024

I think we should update the Makefile i.e. add genotelcontribcol step for both docker and binary targets, @mowies @atoulme @andrzej-stencel What are your thoughts on it? I can help with it, if you want.

@mowies
Copy link
Member

mowies commented Oct 8, 2024

Yeah i think we should add the generate targets where needed. I'll create a PR

@BharatKJain
Copy link

BharatKJain commented Oct 9, 2024

My vscode debugger is also failing, any suggestions for it? Please help!

It was working before... 😞

launch.json:

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch file",
            "cwd": "${workspaceRoot}/cmd/otelcontribcol",
            "type": "go",
            "trace": "verbose",
            "logOutput": "dap",
            "showLog": true,
            "request": "launch",
            "mode": "debug",
            "env": {"GO111MODULE": "on","CGO_ENABLED": "0"},
            "program": "${workspaceRoot}/cmd/otelcontribcol",
            "args": ["--config", "./../../test-config-exporter-gelf.yaml"]
        } 
    ]
}
2024-10-09T22:03:25+05:30 debug layer=dap program exited with error: signal: segmentation fault
2024-10-09T22:03:25+05:30 debug layer=dap [-> to client]{"seq":0,"type":"event","event":"output","body":{"category":"console","output":"Process 3051 has exited with status -1\n"}}

jmichalek132 pushed a commit to jmichalek132/opentelemetry-collector-contrib that referenced this issue Oct 10, 2024
…metry#35707)

Fixes open-telemetry#35631

No changelog since this does not affect anyone outside this repo.

Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment