Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [receiver/k8scluster] Add optional k8s.container.status.waiting metric #35668

Closed
wants to merge 1 commit into from

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Oct 8, 2024

Description

Adds optional k8s.container.status.waiting metric, which tracks if container is in waiting state or not.

This is same exact thing what Kube State Metrics does with kube_pod_container_status_waiting.

Link to tracking issue

Fixes #32457

Testing

  • added unit tests

Documentation

@povilasv povilasv marked this pull request as ready for review October 8, 2024 10:28
@povilasv povilasv requested a review from a team as a code owner October 8, 2024 10:28
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this, but we need to pair it with a semconv PR to propose the metric: open-telemetry/semantic-conventions#1032

@povilasv
Copy link
Contributor Author

povilasv commented Oct 9, 2024

@TylerHelmuth Wouldn't we want to first have implementation? In my opinion it would be great to test it in production and check whether it fits our needs / works the way we want to.

As if we add this first to semconv it will be set in stone forever? And in collector we have ways to deprecated and delete non useful metrics 🤔

@TylerHelmuth
Copy link
Member

Yes but also k8s semantic convention stabilization stuff has just started and I want to be cautious about adding a metric that will quickly change. Reducing the amount of breaking changes (because there will be some) would be nice.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 1, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[k8scluster] add k8s.container.status_waiting_reason metric
2 participants