-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container.health and container.status to container attributes #1515
Comments
Hey @Markus78! Could these be modeled as metrics like the My second question is if these two metrics could be re-used as K8s related metrics as well. For example there is https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/k8sclusterreceiver/documentation.md#k8scontainerready but I'm not sure if we could expand here and have a common set of metrics for both K8s and generic containers. Also there is open-telemetry/opentelemetry-collector-contrib#35668. @povilasv do you have any thoughts on this? /cc @open-telemetry/semconv-container-approvers @open-telemetry/semconv-k8s-approvers |
Some points:
In k8s case it's more like - Waiting, Running, Terminated, Unknown. There is also question whether other container manager have same statuses as well. If they don't, then
|
It seems we would be able to describe state/status/phase metrics using the modeling already used in the hw metrics: |
Agree, this the ContainerState K8s protobufs definition: type ContainerState struct {
// Details about a waiting container
// +optional
Waiting *ContainerStateWaiting `json:"waiting,omitempty" protobuf:"bytes,1,opt,name=waiting"`
// Details about a running container
// +optional
Running *ContainerStateRunning `json:"running,omitempty" protobuf:"bytes,2,opt,name=running"`
// Details about a terminated container
// +optional
Terminated *ContainerStateTerminated `json:"terminated,omitempty" protobuf:"bytes,3,opt,name=terminated"`
} |
Area(s)
area:container
Is your change request related to a problem? Please describe.
It is usefull to be able to the tell the health and status of running containers in docker or podman. These attributes would make it easier to keep track of the status of containers and their health.
Describe the solution you'd like
I would like 2 new attributes for containers
Name:
container.health
integer with the following definitionsName:
container.status
integer with the following definitionsThese 2 attributes makes overview of running containers possible. Inspiration from prometheus-podman-exporter
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: