[chore][CODEOWNERS] Update code owners #34622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This will resolve failing |
songy23
approved these changes
Aug 12, 2024
codeboten
approved these changes
Aug 12, 2024
dmitryax
approved these changes
Aug 12, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** As a result of open-telemetry#34585, open-telemetry#34015, and open-telemetry#34572, we've had some inconsistencies and incorrect information introduced around code owners. This corrects these errors by updating `metadata.yaml` to match the `CODEOWNERS` file, as well as updating `CODEOWNERS` format, and adding a user to the `allowlist` of code owners that are not OpenTelemetry members. I believe there should be more discussion around adding people to the `allowlist`, vs. simply not including as code owners until they become members, but this change simply formats existing code owners, and doesn't change anyone's current status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As a result of #34585, #34015, and #34572, we've had some inconsistencies and incorrect information introduced around code owners. This corrects these errors by updating
metadata.yamlto match theCODEOWNERSfile, as well as updatingCODEOWNERSformat, and adding a user to theallowlistof code owners that are not OpenTelemetry members.I believe there should be more discussion around adding people to the
allowlist, vs. simply not including as code owners until they become members, but this change simply formats existing code owners, and doesn't change anyone's current status.