[receiver/googlecloudmonitoringreceiver] Adding Google Cloud monitoring receiver #34015
Conversation
|
|
github-actions
bot
added
cmd/otelcontribcol
abhishek-at-cloudwerx
force-pushed
the
googlecloudmonitoringreceiver-phase1
branch
from
dff685d
to
97ff395
Compare
|
Hello @abhishek-at-cloudwerx, please sign the CLA to enable this PR to be reviewed. |
|
@crobert-1 - Yes we're working on getting the org CLA sorted. Unfortunately we are unable to get any help in figuring out who registered as Org admin. |
|
@crobert-1 - The CLA is now signed and PR is ready for review. @dashpole - Tagging as Sponsor |
|
@dashpole I made the changes as per your comment and removed the service_name field since we now fetch details directly based on the metric_name. |
There was a problem hiding this comment.
LGTM after nits addressed, @TylerHelmuth should review as well
|
@TylerHelmuth @dashpole - Could one of you help merge this ? |
|
Thanks @TylerHelmuth for approval. @djaglowski could you please help with the final approval and merge as CODEOWNER. |
There was a problem hiding this comment.
@abhishek-at-cloudwerx LGTM but I'm not a codeowner on this component.
dashpole
added
the
ready to merge
|
Still some presubmit failures |
@dashpole - Yes we're currently reviewing those and will drop a note once all is in good shape. |
…y-collector-contrib into googlecloudmonitoringreceiver-phase1
dashpole
added
the
ready to merge
**Description:** As a result of #34585, #34015, and #34572, we've had some inconsistencies and incorrect information introduced around code owners. This corrects these errors by updating `metadata.yaml` to match the `CODEOWNERS` file, as well as updating `CODEOWNERS` format, and adding a user to the `allowlist` of code owners that are not OpenTelemetry members. I believe there should be more discussion around adding people to the `allowlist`, vs. simply not including as code owners until they become members, but this change simply formats existing code owners, and doesn't change anyone's current status.
…ng receiver (open-telemetry#34015) **Description:** Adding Google Cloud Monitoring receiver Closes open-telemetry#33762 **Testing:** Test cases for configuration added **Documentation:** README file added for describing the component
**Description:** As a result of open-telemetry#34585, open-telemetry#34015, and open-telemetry#34572, we've had some inconsistencies and incorrect information introduced around code owners. This corrects these errors by updating `metadata.yaml` to match the `CODEOWNERS` file, as well as updating `CODEOWNERS` format, and adding a user to the `allowlist` of code owners that are not OpenTelemetry members. I believe there should be more discussion around adding people to the `allowlist`, vs. simply not including as code owners until they become members, but this change simply formats existing code owners, and doesn't change anyone's current status.
Description: Adding Google Cloud Monitoring receiver
Link to tracking Issue: #33762
Testing: Test cases for configuration added
Documentation: README file added for describing the component