Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Protocol with Apache Arrow Receiver initial skeleton #30766

Merged
merged 37 commits into from
Feb 7, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jan 24, 2024

Description:
First PR to introduce the OpenTelemetry Protocol with Apache Arrow receiver. From the upstream repository: https://github.com/open-telemetry/otel-arrow/blob/main/collector/receiver/otelarrowreceiver.

Similar to #30619 for the corresponding receiver.

Link to tracking Issue: #26491

Testing:
This is a skeleton PR, therefore only the skeleton contains tests. Compared with the upstream repository, the factory_test.go and config_test.go files have been kept, the implementation tests in otelarrow_test.go were excluded in this PR.

Documentation: New README, copied from the upstream repository.

@jmacd jmacd marked this pull request as ready for review January 26, 2024 16:14
@jmacd jmacd requested review from a team and dashpole January 26, 2024 16:14
jmacd added a commit to open-telemetry/otel-arrow that referenced this pull request Jan 26, 2024
Keeping changes in sync between this repo and
open-telemetry/opentelemetry-collector-contrib#30766
Remove two dead files that will be regenerated in contrib.
Remove `otlpReceiver` type name, use `otelArrowReceiver`.
Move sharedcomponent to internal package location.
@jmacd
Copy link
Contributor Author

jmacd commented Jan 30, 2024

It looks like when the base collector version is updated between releases, as has been done, it becomes difficult/impossible to create new components that will pass all the checks. The best solution I've been able to come to (since make update-otel does not help) is to copy the diff from the check failure and apply it by hand. (Stay tuned!)

@jmacd
Copy link
Contributor Author

jmacd commented Jan 31, 2024

🟢

@jmacd
Copy link
Contributor Author

jmacd commented Feb 2, 2024

🟢

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmacd

@codeboten codeboten merged commit ce67d73 into open-telemetry:main Feb 7, 2024
95 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants