Sharecomponent logic lacks error support

[jmacd]

Component(s)

No response

What happened?

Description

Steps to Reproduce

Expected Result

In migrating the otel-arrow code base into this repository, #30766, we observe that the "sharedcomponent" library in this repo is different than the one in core, and deficient in terms of error handling support.

The GetOrCreate() method does not allow the function to return an error. This means the object will be cached whether the constructor succeeds or not, which means that subsequent calls to get the shared component will get an object for which the (shared) constructor returned an error, but the subsequent caller will not see the error.

Actual Result

Notice that the same library in the core repo, which the OTLP receiver uses, allows errors and does not update the cache when there is an error:

https://github.com/open-telemetry/opentelemetry-collector/blob/main/internal/sharedcomponent/sharedcomponent.go

Collector version

v0.93.0

Environment information

n/a

OpenTelemetry Collector configuration

n/a

Log output

n/a

Additional context

The core library also supports generics, which is slightly easier to use. Can we unify these two libraries?

[jmacd]

IMO this change, adapting to a library without error support, both introduces a potential bug --GetOrCreate() returns an object for which an error was already generated -- and yields less-readable code: fce4631

[github-actions]

Pinging code owners for internal/sharedcomponent: @open-telemetry/collector-approvers. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[atoulme]

The goal is to move sharedcomponent from contrib and adopt it from core once it is promoted to component/sharedcomponent. See open-telemetry/opentelemetry-collector#4266

[crobert-1]

Removing needs triage as these are valid concerns, but I acknowledge there's still some ambiguity of when and where the resolution will land.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• internal/sharedcomponent: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• internal/sharedcomponent: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• internal/sharedcomponent: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.