Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SharedComponents public #4266

Open
tigrannajaryan opened this issue Oct 26, 2021 · 3 comments
Open

Make SharedComponents public #4266

tigrannajaryan opened this issue Oct 26, 2021 · 3 comments

Comments

@tigrannajaryan
Copy link
Member

It is currently internal and only used by OTLP receiver however there are other receivers that need the same functionality (any receiver that implements more than one data type needs this).

We have a duplicate in the contrib repo which is used by some contrib receivers, which is also internal. Any distro that implements a receiver like this is also forced to reimplement the SharedComponent.

I think we can simply make it public in the core and use everywhere (not sure if there is any other reason to keep it internal).

cc @bogdandrutu

@bogdandrutu
Copy link
Member

There needs to be an API review, and find the right spot to have that. Maybe "pkg/sharedcomponents"?

@tigrannajaryan
Copy link
Member Author

There needs to be an API review, and find the right spot to have that. Maybe "pkg/sharedcomponents"?

Another possibility: component/componenthelper.

@RuoyuDai
Copy link

RuoyuDai commented Sep 7, 2022

There needs to be an API review, and find the right spot to have that. Maybe "pkg/sharedcomponents"?

Move from internal/sharedcomponent into component/sharedcomponent ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants