[chore][extension/encoding] add test cases covering encoding extension #28683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
add-encoding-extension
branch
4 times, most recently
from
a4e526e
to
5a4169c
Compare
VihasMakwana
force-pushed
the
add-encoding-extension
branch
7 times, most recently
from
ccbbeb4
to
b83727c
Compare
dmitryax
reviewed
Oct 30, 2023
|
I submitted another PR to introduce explicit interfaces for the encoding extension, PTAL #28688 |
|
@dmitryax Cool, I'll wait for your PR to get merged. I'll keep this PR open and limit it only to cover test cases.
|
VihasMakwana
changed the title
VihasMakwana
force-pushed
the
add-encoding-extension
branch
from
582e9a8
to
5f330ca
Compare
VihasMakwana
force-pushed
the
add-encoding-extension
branch
4 times, most recently
from
6977610
to
9c0a51d
Compare
VihasMakwana
force-pushed
the
add-encoding-extension
branch
2 times, most recently
from
6979cc8
to
8508fe5
Compare
|
@dmitryax can we get this merged? |
|
Conflict, please rebase |
atoulme
removed
the
ready to merge
atoulme
approved these changes
Dec 11, 2023
VihasMakwana
force-pushed
the
add-encoding-extension
branch
from
538c7d2
to
4487d96
Compare
|
@VihasMakwana final steps, solve conflicts and let it get merged :-P |
Co-authored-by: Vihas Splunk <[email protected]>
atoulme
force-pushed
the
add-encoding-extension
branch
from
4487d96
to
5aa17ca
Compare
atoulme
added
the
ready to merge
|
I have rebased and squashed and pushed - sorry for the intrusion, just trying to get this merged. Marked as "ready to merge" |
88 tasks
|
Failing test: |
atoulme
approved these changes
Jan 8, 2024
dmitryax
approved these changes
Jan 8, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
open-telemetry#28683) **Description:** This PR does the following: - Test cases for all the known encoding extensions - Add extensions to builder and update components.go - Run `make crosslink` I believe we can use this extension for `pulsarreceiver` for now and see how it performs in production. I will raise a follow-up PR after this one. **Link to tracking Issue:** open-telemetry#28686 --------- Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR does the following:
make crosslinkI believe we can use this extension for
pulsarreceiverfor now and see how it performs in production. I will raise a follow-up PR after this one.Link to tracking Issue: #28686