Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/collectd] remove opencensus #28657

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 27, 2023

Description:
use telemetry settings, don't rely on opencensus for component metrics

Link to tracking Issue:
Fixes #25148

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change to ensure the metric naming isn't broken. If the metric naming changes, the breaking change procedure should be followed :)

@atoulme
Copy link
Contributor Author

atoulme commented Oct 27, 2023

Breaking it all the way - no more metrics, let's use obsrecv instead.

@atoulme atoulme force-pushed the use_meter_collectd branch from 6cb648d to 2840d32 Compare October 27, 2023 20:54
@atoulme atoulme force-pushed the use_meter_collectd branch from 2840d32 to fadd68d Compare October 27, 2023 23:18
@atoulme atoulme force-pushed the use_meter_collectd branch from fadd68d to 3f0c463 Compare October 27, 2023 23:46
@atoulme atoulme requested a review from codeboten October 28, 2023 00:23
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok since the component is still marked as alpha, for beta components i would expect this change would require a feature gate 👍🏻

@atoulme
Copy link
Contributor Author

atoulme commented Oct 30, 2023

Indeed. Note I have opened an issue to move this component to beta here: #28658 and am doing this change now because of it, partially.

@codeboten codeboten merged commit 114441f into open-telemetry:main Oct 30, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 30, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
use telemetry settings, don't rely on opencensus for component metrics

Fixes open-telemetry#25148
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
use telemetry settings, don't rely on opencensus for component metrics

Fixes open-telemetry#25148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/collectd] Refactor Observability.go from opencensus to pdata
4 participants