Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/collectd] Refactor Observability.go from opencensus to pdata #25148

Closed
ZenoCC-Peng opened this issue Aug 10, 2023 · 2 comments · Fixed by #28657
Closed

[receiver/collectd] Refactor Observability.go from opencensus to pdata #25148

ZenoCC-Peng opened this issue Aug 10, 2023 · 2 comments · Fixed by #28657
Labels
enhancement New feature or request receiver/collectd

Comments

@ZenoCC-Peng
Copy link
Contributor

Component(s)

receiver/collectd

Is your feature request related to a problem? Please describe.

Hi,
I hope someone can refactor collectdreceiver/observability.go.
It appears that certain sections of the code still rely on opencensus.

import (
	"context"

	"go.opencensus.io/stats"
	"go.opencensus.io/stats/view"
)

Furthermore, I've noticed that there are other collectors that also employ similar logic for handling observability.go (ex: k8sattributesprocessor).

Describe the solution you'd like

Hope people can reactor part of observability.go to pdata.

Describe alternatives you've considered

No response

Additional context

From what I know, the purpose of this code is to record events of success and failure.

I've seen someone use module obsreport in opentelemetry-collector-contrib to achieve similar functionality, For example, in the splunkhecreceiver.

However, the metric mode in obsreport refers to "go.opentelemetry.io/otel/metric," which refers from https://pkg.go.dev/go.opentelemetry.io/otel/metric and it's different from "pmetric".

@ZenoCC-Peng ZenoCC-Peng added enhancement New feature or request needs triage New item requiring triage labels Aug 10, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Aug 10, 2023
@ZenoCC-Peng ZenoCC-Peng changed the title [receiver/collectd] Refactor Observability.go to pdata [receiver/collectd] Refactor Observability.go from opencensus to pdata Aug 10, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 10, 2023
@atoulme atoulme removed the Stale label Oct 27, 2023
codeboten pushed a commit that referenced this issue Oct 30, 2023
use telemetry settings, don't rely on opencensus for component metrics

Fixes #25148
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
use telemetry settings, don't rely on opencensus for component metrics

Fixes open-telemetry#25148
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
use telemetry settings, don't rely on opencensus for component metrics

Fixes open-telemetry#25148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/collectd
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants