Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update collector demo #26675

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Sep 13, 2023

Description:
#26546 removed the jaeger exporter, but the build-and-test workflow depended on that exporter since it uses the config in examples/demo/otel-collector-config.yaml for its test.

This PR updates the demo to use OTLP with jaeger, which also fixes the rpm and deb test job in build-and-test.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to update

to start the collector w/ other ports exposed... likely 4317 will cause collisions though

@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented Sep 13, 2023

@codeboten testing locally things are working - I believe jaeger is doing some magic for us. Traces are making it to jaeger at 4137 despite the port not being exposed

image

image

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerHelmuth huh... i stand corrected! Thanks for validating

@codeboten codeboten merged commit 943b345 into open-telemetry:main Sep 13, 2023
91 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants