Removing deprecated jaeger and jaegerthrifthttp exporters #26546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
jpkrohling,
mx-psi and
dmitryax
as code owners
github-actions
bot
added
cmd/configschema
dmitryax
approved these changes
Sep 8, 2023
frzifus
approved these changes
Sep 9, 2023
mx-psi
approved these changes
Sep 11, 2023
jpkrohling
approved these changes
Sep 11, 2023
This follows the deprecation plan to remove the component. The original removal date was July 2023, it is now past that. Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/rm-jaeger-exporters
branch
from
07a6375 to
33d0a8e
Compare
codeboten
commented
Sep 12, 2023
added 4 commits
September 12, 2023 09:44
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Sep 13, 2023
#26546 removed the jaeger exporter, but the `build-and-test` workflow depended on that exporter since it uses the config in `examples/demo/otel-collector-config.yaml` for its test. This PR updates the demo to use OTLP with jaeger, which also fixes the `rpm` and `deb` test job in `build-and-test`.
|
I updated to v0.85.0 and Jaeger spanmetrics not working in SPM page, worked fine in v0.84.0 with the same settings. In the official Jaeger's tutorial, they use v0.80.0, but I don't want to roll back to old versions. |
|
@bangbaew Can you file a separate issue for this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the deprecation plan to remove the component. The original removal date was July 2023, it is now past that.
Linked issue: open-telemetry/opentelemetry-specification#3551