[ottl/pkg] Remove the ottlarg struct tag for the arguments and rely on field ordering #25705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnishtala-sumo
changed the title
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
rnishtala-sumo
force-pushed
the
remove-struct-tags
branch
5 times, most recently
from
916cad6 to
3ebc818
Compare
rnishtala-sumo
force-pushed
the
remove-struct-tags
branch
from
3ebc818 to
fae54c3
Compare
rnishtala-sumo
changed the title
rnishtala-sumo
changed the title
TylerHelmuth
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
@rnishtala-sumo thanks for handling this. I am going to hold off merging until @evan-bradley has gotten a chance to review next week.
There was a problem hiding this comment.
I like red PRs like this, thanks for taking this on. Could you add an API changelog for this change and update all filterottl and transform processor functions to remove the ottlarg struct tag as well? Since it isn't a user-facing change for the other components I think it would be easier just to remove the tag in one go.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
evan-bradley
approved these changes
Sep 13, 2023
|
@TylerHelmuth @evan-bradley thanks for merging this. Apologies I couldn't get to this earlier as I took some time off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ottlarg struct tag and rely on field ordering
Link to tracking Issue: #24874