Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Remove ottlarg struct tag #24874

Closed
evan-bradley opened this issue Aug 3, 2023 · 2 comments
Closed

[pkg/ottl] Remove ottlarg struct tag #24874

evan-bradley opened this issue Aug 3, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request pkg/ottl priority:p1 High

Comments

@evan-bradley
Copy link
Contributor

Component(s)

pkg/ottl

Is your feature request related to a problem? Please describe.

The ottlarg struct tag was originally introduced to disambiguate the argument ordering of a field in an OTTL Arguments struct. Now that it's been implemented, it doesn't seem like it is worth the additional complexity of handling it in the OTTL parser. Top-to-bottom is a natural way to read the fields, and all of our tags match the field ordering anyway.

Describe the solution you'd like

Make a breaking change as early as possible and remove ottlarg, instead having functions simply rely on field ordering within the Arguments struct.

Describe alternatives you've considered

No response

Additional context

No response

@rnishtala-sumo
Copy link
Contributor

@evan-bradley I could spend some time on this. It does seem like this will have changes that touch all the Functions/Editors.

@evan-bradley
Copy link
Contributor Author

Thanks for volunteering. It will touch a lot of code, but should be a straightforward change since we're removing functionality.

TylerHelmuth pushed a commit that referenced this issue Sep 13, 2023
…n field ordering (#25705)

Remove the ottlarg struct tag and rely on field ordering
**Link to tracking Issue:**
#24874
TylerHelmuth added a commit that referenced this issue Sep 13, 2023
**Description:** 
Removes all instances of `ottlarg`. Followup to
#25705

**Link to tracking Issue:** <Issue number if applicable>

#24874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg/ottl priority:p1 High
Projects
None yet
Development

No branches or pull requests

3 participants