Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: description update #24577

Closed
wants to merge 2 commits into from
Closed

chore: description update #24577

wants to merge 2 commits into from

Conversation

jcountsNR
Copy link

Updated language of description.

@jcountsNR jcountsNR requested a review from a team July 26, 2023 17:54
@jcountsNR jcountsNR requested a review from dmitryax as a code owner July 26, 2023 17:54
@jcountsNR
Copy link
Author

@dmitryax , I made a basic language update. If this can get approved I can automatically run tests on the main PR.

@dmitryax
Copy link
Member

@jcountsNR Sorry, it doesn't seem like an improvement. I'll be inconsistent with other descriptions like Number of partitions in topic.

@dmitryax
Copy link
Member

I'd suggest resolving #10554, which must be pretty simple as well

@dmitryax
Copy link
Member

And don't forget to run make generate to re-generate the code from metadata.yaml

@jcountsNR jcountsNR closed this Jul 26, 2023
@jcountsNR jcountsNR deleted the dev branch July 26, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@mx-psi mx-psi

Labels
receiver/kafkametrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcountsNR @dmitryax @mx-psi