Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafkametricsreceiver] Some metric units don't follow Otel semantic conventions #10554

Closed
bertysentry opened this issue Jun 2, 2022 · 9 comments
Labels
bug Something isn't working closed as inactive good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest receiver/kafkametrics Stale

Comments

@bertysentry
Copy link
Contributor

Describe the bug
Some metrics don't follow Otel semantic conventions

Steps to reproduce
Nothing to reproduce. The problem lies in the specification of the receiver itself.

What did you expect to see?
Metrics about offset should use an empty unit.

Example:

  • kafka.partition.current_offset
  • kafka.partition.oldest_offset
  • kafka.consumer_group.offset
  • etc.

What did you see instead?
Many metrics specify unit 1 to report offset:

  • kafka.partition.current_offset
  • kafka.partition.oldest_offset
  • kafka.consumer_group.offset
  • etc.

Unit 1 must be used only for fractions and ratios.

What version did you use?
Main branch

What config did you use?
N/A

Environment
N/A

Additional context
N/A

@bertysentry bertysentry added the bug Something isn't working label Jun 2, 2022
@djaglowski djaglowski added the priority:p3 Lowest label Jun 10, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2023
@dmitryax dmitryax added help wanted Extra attention is needed and removed Stale closed as inactive labels May 26, 2023
@dmitryax dmitryax reopened this May 26, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 25, 2023
@dmitryax dmitryax added good first issue Good for newcomers and removed Stale labels Sep 25, 2023
@bertysentry
Copy link
Contributor Author

I hope someone can fix that, it's a very simple change, after all. With the new Otel-to-Prometheus conversion mechanism in place, these metrics with unit 1 will have a _ratio suffix appended to their name in Prometheus.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.
  • receiver/kafkametrics: @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 27, 2023
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
@bertysentry
Copy link
Contributor Author

ping (bump?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed as inactive good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest receiver/kafkametrics Stale
Projects
None yet
Development

No branches or pull requests

4 participants