[receiver/skywalking]: Refactor code structure/directory #20344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Restructuring the directory/structure 2. Adding an HTTP trace Reception unit test
|
|
github-actions
bot
added
cmd/otelcontribcol
aheling11
force-pushed
the
skywalking_add_metric
branch
from
45cbe01 to
9226821
Compare
aheling11
requested review from
djaglowski,
jpkrohling,
Aneurysm9,
dmitryax and
kovrus
as code owners
github-actions
bot
added
exporter/elasticsearch
exporter/signalfx
extension/basicauth
extension/headerssetter
extension/healthcheck
aheling11
force-pushed
the
skywalking_add_metric
branch
from
71c3ae6 to
c085000
Compare
|
Tests started. |
|
@aheling11 CI passed, Let's wait for the approver to merge this PR. |
|
There were some conflicts in the go.sum, but they have been resolved. |
…y-collector-contrib into skywalking_add_metric # Conflicts: # receiver/skywalkingreceiver/go.mod # receiver/skywalkingreceiver/go.sum # receiver/skywalkingreceiver/tracing_report_service.go
|
Could you please rerun the tests? I have resolved some conflicts. @jpkrohling |
|
@aheling11 new conflicts :-P |
…y-collector-contrib into skywalking_add_metric # Conflicts: # receiver/skywalkingreceiver/factory.go # receiver/skywalkingreceiver/factory_test.go
resolved again ~ |
JaredTan95
approved these changes
May 15, 2023
|
Why doesn't GitHub have a feature to retract review requests? I accidentally clicked the "Request review" button. =-= |
|
That's ok, take easy~, let's waiting maintainer to merge it. |
fatsheep9146
approved these changes
May 16, 2023
…y-collector-contrib into skywalking_add_metric # Conflicts: # receiver/skywalkingreceiver/tracing_report_service.go
|
resolve conflict again. |
|
ping @open-telemetry/collector-contrib-maintainer I think this pr is ready to be merged |
atoulme
approved these changes
May 19, 2023
atoulme
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
1st PR: In order to add metrics receiver to skywalking/receiver, I found that I need to adjust the code directory/code structure a bit. So this PR is just a code refactoring, referring to the structure of otlp/receiver. After that, it will be easier for skywalking/receiver to add metrics or logs to the receiver.
The new swReceiver struct is shown below.
Link to tracking Issue:
#20315
Testing:
The original unit tests have been passed, and a test for HTTP reception has been added. Because of some restructuring, the unit test code has changed a bit.
Documentation: