Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/skywalking]Need to achieve the collection of metric data #20315

Closed
aheling11 opened this issue Mar 25, 2023 · 13 comments
Closed

[receiver/skywalking]Need to achieve the collection of metric data #20315

aheling11 opened this issue Mar 25, 2023 · 13 comments
Assignees
@aheling11
Labels
comp:skywalking enhancement New feature or request receiver/skywalking

Comments

@aheling11
Copy link
Contributor

aheling11 commented Mar 25, 2023 •
edited
Loading

Component(s)

receiver/skywalking

Is your feature request related to a problem? Please describe.

I found that skywalking receiver can only accept tracing data, metrics like JVM runtime metrics are not supported. And opentelemetry already has a standard for JVM runtime metrics. It would be great if the skywalking receiver could also support metrics such as JVM runtime metrics and convert them into otlp metrics

Describe the solution you'd like

I noticed that the skywalking receiver has reserved the Collect interface for JVM metrics. Just implement the interface and translate the data format to otlp.

Describe alternatives you've considered

No response

Additional context

No response
@aheling11 aheling11 added enhancement New feature or request needs triage New item requiring triage labels Mar 25, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95
Copy link
Member

Thank you for your proposal, which is also a feature I intend to implement soon.
But I may not be able to dedicate immediate energy to achieving it lately.
If you want, your contribution is also welcome :-P

@aheling11
Copy link
Contributor Author

I'll be happy to implement this feature
please assign this issure to me :)

@fatsheep9146 fatsheep9146 removed the needs triage New item requiring triage label Mar 25, 2023
@fatsheep9146
Copy link
Contributor

It's yours! @aheling11

@aheling11 aheling11 mentioned this issue Mar 27, 2023
Merged
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 25, 2023
@JaredTan95
Copy link
Member

hi, @aheling11 How is it going? just friendly ping make this issue no-stale :-P

@JaredTan95 JaredTan95 removed the Stale label May 25, 2023
@aheling11
Copy link
Contributor Author

hi, @aheling11 How is it going? just friendly ping make this issue no-stale :-P

hi, after completing the first step of the code refactoring, I'm currently finishing up the remaining parts. :)

@maokitty
Copy link

maokitty commented Aug 8, 2023

hi, @aheling11 are you still working on the remaining parts? i have some needs for the skywalking jvm metric recently, if you are still working on it just ignore me or i can see what i can do for this issue

@fatsheep9146
Copy link
Contributor

@maokitty could you take this issue?

@aheling11
Copy link
Contributor Author

hi, @aheling11 are you still working on the remaining parts? i have some needs for the skywalking jvm metric recently, if you are still working on it just ignore me or i can see what i can do for this issue

I'm sorry for not following up on this for a long time. I have completed half of the remaining work and will submit a PR to merge the code into the main branch as soon as possible.

This was referenced Aug 27, 2023
Closed
Merged
@jiekun
Copy link
Member

jiekun commented Sep 15, 2023

Thanks for your contribution. I'm also looking for a receiver to collect some jvm metrics reported by skywalking SDK. Looking forward to next release!

jpkrohling pushed a commit that referenced this issue Sep 20, 2023
@aheling11
[receiver/skywalking] Add skywalking jvm metric receiver (#26315)
be54bf6 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Adding a JVM receiver in Skywalking and translate most of the metrics
into the OpenTelemetry format according to the [OT JVM semantic
conventions.](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/jvm/jvm-metrics.md)
However, for the GC metrics, as the metric type is like gauge while the
corresponding metric in the semantic conventions `jvm.gc.duration`is
histogram type, I'm not translate it strictly according to the semantic
conventions.
**Link to tracking Issue:** <Issue number if applicable>
#20315 
**Testing:** <Describe what testing was performed and which tests were
added.>

test it locally. I export the metrics to Prometheus and display them in
Grafana.
<img width="1767" alt="image"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/30763743/97541490-d969-4a28-b5d8-87a04dd25b1d">


**Documentation:** <Describe the documentation added.>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@aheling11 @jmsnll
[receiver/skywalking] Add skywalking jvm metric receiver (open-teleme…
d8d544d 
…try#26315)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Adding a JVM receiver in Skywalking and translate most of the metrics
into the OpenTelemetry format according to the [OT JVM semantic
conventions.](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/jvm/jvm-metrics.md)
However, for the GC metrics, as the metric type is like gauge while the
corresponding metric in the semantic conventions `jvm.gc.duration`is
histogram type, I'm not translate it strictly according to the semantic
conventions.
**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#20315 
**Testing:** <Describe what testing was performed and which tests were
added.>

test it locally. I export the metrics to Prometheus and display them in
Grafana.
<img width="1767" alt="image"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/30763743/97541490-d969-4a28-b5d8-87a04dd25b1d">


**Documentation:** <Describe the documentation added.>
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 15, 2023
@jiekun
Copy link
Member

jiekun commented Nov 15, 2023

I assume this feature is implemented with #26315 ?

@github-actions github-actions bot removed the Stale label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aheling11 aheling11

Labels
comp:skywalking enhancement New feature or request receiver/skywalking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpkrohling @maokitty @fatsheep9146 @JaredTan95 @jiekun @aheling11