Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enabled flag for attributes to metadata.yaml #16736

Merged

Conversation

hughesjj
Copy link
Contributor

@hughesjj hughesjj commented Dec 6, 2022

Description: Adds an Enabled configuration option to metric generators so that receiver authors can add new attributes without forcing all existing consumers to use such.

Link to tracking Issue: 16373

Testing: make mdatagen-test && make generate
To verify I hit all of the resource_attributes in the various metadata.yaml, I installed yq and ran the below

rm resource_attr_metadata_yaml.log && grep -R --files-with-matches "resource_attributes" **/metadata.yaml | xargs yq .resource_attributes - >> resource_attr_metadata_yaml.log && echo "$(grep description resource_attr_metadata_yaml.log | wc -l) vs $(grep enabled resource_attr_metadata_yaml.log | wc -l)"
97 vs 97

I find it best to run something like this for new commits to this PR
make mdatagen-test && make generate && make otelcontribcol && git add -u && git commit -m "Meaningful update text" && git push

Documentation: None, other than changes to generated documentation.

@hughesjj hughesjj requested a review from a team December 6, 2022 18:21
@hughesjj hughesjj marked this pull request as draft December 6, 2022 18:21
cmd/mdatagen/loader.go Outdated Show resolved Hide resolved
@runforesight
Copy link

runforesight bot commented Dec 7, 2022

Foresight Summary

    
Major Impacts

build-and-test-windows duration(7 seconds) has decreased 41 minutes 13 seconds compared to main branch avg(41 minutes 20 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 7 seconds (41 minutes 13 seconds less than main branch avg.) and finished at 18th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 51 seconds and finished at 18th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 2 minutes 30 seconds and finished at 18th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 2 minutes 36 seconds (⚠️ 1 minute more than main branch avg.) and finished at 18th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 50 seconds (⚠️ 45 seconds more than main branch avg.) and finished at 18th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 56 seconds (3 minutes 36 seconds less than main branch avg.) and finished at 18th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 40 minutes 48 seconds (6 minutes 55 seconds less than main branch avg.) and finished at 18th Jan, 2023.


Job Failed Steps Tests
unittest-matrix (1.18, internal) -     🔗  ✅ 666  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 666  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1488  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1488  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2565  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2565  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2474  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2474  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4467  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4467  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1894  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1894  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
checks -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

✅  load-tests workflow has finished in 8 minutes 51 seconds (5 minutes 9 seconds less than main branch avg.) and finished at 18th Jan, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@hughesjj hughesjj force-pushed the add_metadata_to_resource_attribute branch from 131de32 to 7530b67 Compare January 11, 2023 18:11
cmd/mdatagen/metadata.yaml Outdated Show resolved Hide resolved
cmd/mdatagen/templates/documentation.md.tmpl Outdated Show resolved Hide resolved
cmd/mdatagen/templates/metrics.go.tmpl Outdated Show resolved Hide resolved
@hughesjj hughesjj force-pushed the add_metadata_to_resource_attribute branch 6 times, most recently from ca92453 to 352ded1 Compare January 15, 2023 22:23
cmd/mdatagen/loader.go Outdated Show resolved Hide resolved
cmd/mdatagen/testdata/documentation.md Outdated Show resolved Hide resolved
@hughesjj hughesjj force-pushed the add_metadata_to_resource_attribute branch 2 times, most recently from 695dbd4 to d86b651 Compare January 17, 2023 20:07
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits. Otherwise, LGTM. Please move if from draft once comments are addressed

cmd/mdatagen/loader_test.go Outdated Show resolved Hide resolved
cmd/mdatagen/templates/metrics_test.go.tmpl Outdated Show resolved Hide resolved
cmd/mdatagen/templates/metrics_test.go.tmpl Outdated Show resolved Hide resolved
cmd/mdatagen/templates/metrics_test.go.tmpl Outdated Show resolved Hide resolved
@hughesjj hughesjj marked this pull request as ready for review January 18, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants