-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enabled flag for attributes to metadata.yaml #16736
Merged
dmitryax
merged 9 commits into
open-telemetry:main
from
hughesjj:add_metadata_to_resource_attribute
Jan 18, 2023
Merged
Add Enabled flag for attributes to metadata.yaml #16736
dmitryax
merged 9 commits into
open-telemetry:main
from
hughesjj:add_metadata_to_resource_attribute
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughesjj
requested review from
djaglowski,
dmitryax,
dashpole,
codeboten and
MovieStoreGuy
as code owners
December 6, 2022 18:21
bogdandrutu
reviewed
Dec 6, 2022
Foresight Summary
View More Details⭕ build-and-test-windows workflow has finished in 7 seconds (41 minutes 13 seconds less than
|
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 1 minute 51 seconds and finished at 18th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ telemetrygen workflow has finished in 2 minutes 30 seconds and finished at 18th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 2 minutes 36 seconds (⚠️ 1 minute more than main
branch avg.) and finished at 18th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
✅ changelog workflow has finished in 2 minutes 50 seconds (⚠️ 45 seconds more than main
branch avg.) and finished at 18th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 56 seconds (3 minutes 36 seconds less than main
branch avg.) and finished at 18th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
✅ build-and-test workflow has finished in 40 minutes 48 seconds (6 minutes 55 seconds less than main
branch avg.) and finished at 18th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
unittest-matrix (1.18, internal) | - 🔗 | ✅ 666 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, internal) | - 🔗 | ✅ 666 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, processor) | - 🔗 | ✅ 1488 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, processor) | - 🔗 | ✅ 1488 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, extension) | - 🔗 | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-metrics | - 🔗 | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-traces | - 🔗 | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, extension) | - 🔗 | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-0) | - 🔗 | ✅ 2565 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-0) | - 🔗 | ✅ 2565 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, exporter) | - 🔗 | ✅ 2474 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, exporter) | - 🔗 | ✅ 2474 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, other) | - 🔗 | ✅ 4467 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | - 🔗 | ✅ 4467 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-1) | - 🔗 | ✅ 1894 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | - 🔗 | ✅ 1894 ❌ 0 ⏭ 0 🔗 | See Details |
integration-tests | - 🔗 | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
checks | - 🔗 | N/A | See Details |
check-collector-module-version | - 🔗 | N/A | See Details |
check-codeowners | - 🔗 | N/A | See Details |
build-examples | - 🔗 | N/A | See Details |
lint-matrix (receiver-0) | - 🔗 | N/A | See Details |
lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
lint-matrix (processor) | - 🔗 | N/A | See Details |
lint-matrix (exporter) | - 🔗 | N/A | See Details |
lint-matrix (extension) | - 🔗 | N/A | See Details |
lint-matrix (internal) | - 🔗 | N/A | See Details |
lint-matrix (other) | - 🔗 | N/A | See Details |
lint | - 🔗 | N/A | See Details |
unittest (1.19) | - 🔗 | N/A | See Details |
unittest (1.18) | - 🔗 | N/A | See Details |
cross-compile (darwin, amd64) | - 🔗 | N/A | See Details |
cross-compile (darwin, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, 386) | - 🔗 | N/A | See Details |
cross-compile (linux, amd64) | - 🔗 | N/A | See Details |
cross-compile (linux, arm) | - 🔗 | N/A | See Details |
cross-compile (linux, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, ppc64le) | - 🔗 | N/A | See Details |
cross-compile (windows, 386) | - 🔗 | N/A | See Details |
cross-compile (windows, amd64) | - 🔗 | N/A | See Details |
build-package (deb) | - 🔗 | N/A | See Details |
build-package (rpm) | - 🔗 | N/A | See Details |
windows-msi | - 🔗 | N/A | See Details |
publish-check | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
publish-dev | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 8 minutes 51 seconds (5 minutes 9 seconds less than main
branch avg.) and finished at 18th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
dmitryax
reviewed
Dec 7, 2022
hughesjj
force-pushed
the
add_metadata_to_resource_attribute
branch
from
December 12, 2022 03:51
43af478
to
16a5629
Compare
github-actions
bot
added
cmd/mdatagen
mdatagen command
receiver/activedirectoryds
receiver/aerospike
receiver/apache
receiver/bigip
receiver/chrony
receiver/couchdb
receiver/dockerstats
receiver/elasticsearch
receiver/expvar
receiver/flinkmetrics
receiver/hostmetrics
receiver/httpcheck
HTTP Check receiver
receiver/iis
receiver/kafkametrics
receiver/kubeletstats
receiver/memcached
receiver/mongodb
labels
Dec 12, 2022
hughesjj
force-pushed
the
add_metadata_to_resource_attribute
branch
from
January 11, 2023 18:11
131de32
to
7530b67
Compare
dmitryax
reviewed
Jan 12, 2023
hughesjj
force-pushed
the
add_metadata_to_resource_attribute
branch
6 times, most recently
from
January 15, 2023 22:23
ca92453
to
352ded1
Compare
dmitryax
reviewed
Jan 17, 2023
hughesjj
force-pushed
the
add_metadata_to_resource_attribute
branch
2 times, most recently
from
January 17, 2023 20:07
695dbd4
to
d86b651
Compare
hughesjj
commented
Jan 17, 2023
dmitryax
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits. Otherwise, LGTM. Please move if from draft once comments are addressed
Co-authored-by: Dmitrii Anoshin <[email protected]>
Co-authored-by: Dmitrii Anoshin <[email protected]>
dmitryax
approved these changes
Jan 18, 2023
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/mdatagen
mdatagen command
receiver/activedirectoryds
receiver/aerospike
receiver/apache
receiver/bigip
receiver/chrony
receiver/couchdb
receiver/dockerstats
receiver/elasticsearch
receiver/expvar
receiver/flinkmetrics
receiver/haproxy
receiver/hostmetrics
receiver/httpcheck
HTTP Check receiver
receiver/iis
receiver/kafkametrics
receiver/kubeletstats
receiver/memcached
receiver/mongodb
receiver/mongodbatlas
receiver/mysql
receiver/nginx
receiver/nsxt
NSXT Receiver
receiver/oracledb
receiver/postgresql
receiver/rabbitmq
receiver/redis
Redis related issues
receiver/riak
receiver/saphana
receiver/sqlserver
receiver/vcenter
receiver/zookeeper
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds an Enabled configuration option to metric generators so that receiver authors can add new attributes without forcing all existing consumers to use such.
Link to tracking Issue: 16373
Testing:
make mdatagen-test && make generate
To verify I hit all of the
resource_attributes
in the variousmetadata.yaml
, I installedyq
and ran the belowI find it best to run something like this for new commits to this PR
make mdatagen-test && make generate && make otelcontribcol && git add -u && git commit -m "Meaningful update text" && git push
Documentation: None, other than changes to generated documentation.