-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metrics builder] Add ability to enable/disable resource attributes #16373
Comments
for visibility: I hashed out most of the impl yesterday, currently debugging tests, and will probably reach out to Dmitrii for a second look @ the logic to exclude resource attrs in draft before publicizing. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue is resolved, right ? @dmitryax |
Right, this PR will resolve it |
User should be able to enable and disable resource attributes the same way as it's currently done for metrics:
metadata.yaml interface changes for receiver authors
All resource attributes should get an additional field
enabled
. For now, let's keep all the existing attributes enabled by default, but receiver authors will be able to add (or turn existing) resource attributes into optional attributes. hostmetrics/processscraper example:User config interface changes
This capability should generate additional struct for user configs that receiver authors have to include in their config the same way as done for
MetricsSettings
. Using the same example forprocess.pid
resource attribute, the generated structs should look like this:The text was updated successfully, but these errors were encountered: