Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] Add process.start resource attribute #14479

Conversation

andrzej-stencel
Copy link
Member

@andrzej-stencel andrzej-stencel commented Sep 26, 2022

Description:

This adds a resource attribute named process.start, in alignment with the Elastic Common Schema, to the metrics scraped by the process scraper of the hostmetrics receiver.

Link to tracking Issue:

Context:

Here's a discussion about the semantic convention for the attribute:

I'm not sure if changes to the semantic conventions are currently accepted, as described in these comments, but perhaps emitting an attribute that is already described by the Elastic Common Schema can be accepted?

@andrzej-stencel andrzej-stencel requested a review from a team September 26, 2022 14:07
@andrzej-stencel andrzej-stencel force-pushed the add-process-start-attribute branch from 7f3b656 to d59874f Compare September 26, 2022 14:10
@andrzej-stencel andrzej-stencel changed the title [receiver/hostmetrics]: add process.start resource attribute [receiver/hostmetrics] Add process.start resource attribute Sep 30, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-start-attribute branch 2 times, most recently from d939eb5 to 86b55f9 Compare October 3, 2022 10:49
@Aneurysm9
Copy link
Member

I think this would be blocked as the project charter for the instrumentation stability project explicitly calls out the OTEP for including ECS support as blocked. I think this attribute in particular would also fall into the concern regarding adding high-cardinality attributes to metrics.

@andrzej-stencel
Copy link
Member Author

I think this would be blocked as the project charter for the instrumentation stability project explicitly calls out the OTEP for including ECS support as blocked. I think this attribute in particular would also fall into the concern regarding adding high-cardinality attributes to metrics.

Thanks for the comment Anthony. Yeah, I recognize the attribute is a bit controversial both from the schema and cardinality perspective. There's a discussion on these topics in the specification repository too - both in the issue and in the pull request.

@andrzej-stencel andrzej-stencel force-pushed the add-process-start-attribute branch 2 times, most recently from 42aef9c to a5928a6 Compare October 24, 2022 10:08
@andrzej-stencel andrzej-stencel force-pushed the add-process-start-attribute branch from a5928a6 to c8aab87 Compare October 24, 2022 10:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 9, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants