[pkg/stanza] Use storage extension only if specified #13418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-storage-extname
branch
2 times, most recently
from
4c616bc to
7917d3c
Compare
This was referenced Aug 18, 2022
djaglowski
force-pushed
the
pkg-stanza-storage-extname
branch
from
7917d3c to
d3bc78f
Compare
Previous behavior allowed stanza-based receivers to automatically detect and use a storage extension. This implicit behavior was not clear and precluded the abilty to choose one of multiple storage extensions. This change adds a 'storage' field to stanza-based receivers and requires the user to name the extension that should be used.
djaglowski
force-pushed
the
pkg-stanza-storage-extname
branch
from
d3bc78f to
8c3a416
Compare
|
@open-telemetry/collector-contrib-approvers, please take a look. |
djaglowski
force-pushed
the
pkg-stanza-storage-extname
branch
from
d0ad415 to
68a9269
Compare
TylerHelmuth
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior allowed stanza-based receivers to automatically
detect and use a storage extension. This implicit behavior was not
clear and precluded the abilty to choose one of multiple storage
extensions. This change adds a 'storage' field to stanza-based
receivers and requires the user to name the extension that should
be used.
This PR iterates on #13086 for testing purposes.
Resolves #10915
Replaces #12871