Make sure filelog receiver uses file_storage for checkpointing #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvaghani221
changed the title
dmitryax
reviewed
Oct 21, 2022
atoulme
approved these changes
Oct 31, 2022
jvoravong
added a commit
to jvoravong/splunk-otel-collector-chart
that referenced
this pull request
Dec 2, 2022
jvoravong
added a commit
to jvoravong/splunk-otel-collector-chart
that referenced
this pull request
Dec 3, 2022
jvoravong
added a commit
to jvoravong/splunk-otel-collector-chart
that referenced
this pull request
Dec 3, 2022
vinzent
added a commit
to vinzent/splunk-otel-collector-chart
that referenced
this pull request
Mar 3, 2023
Currently migrated fluentd checkpoint files are not used due to missing storage param to the journald According docs cursors/positions/checkpoints are only persisted on disk, if storage param is given. See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/journaldreceiver/README.md Equivalent to filelog change in signalfx#567
vinzent
added a commit
to vinzent/splunk-otel-collector-chart
that referenced
this pull request
Mar 3, 2023
… attribute If `storage: file_storage` param is not configured, the migrated fluentd position file won't be used and cursor won't ever be persisted to disk. Also the Splunk `source` field is currently missing. This is read by the splunkhec exporter from the `com.splunk.source` attribute. See: * https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/filelogreceiver/README.md * https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/splunkhecexporter/README.md * signalfx#567
dmitryax
pushed a commit
that referenced
this pull request
Mar 3, 2023
Currently migrated fluentd checkpoint files are not used due to missing storage param to the journald According docs cursors/positions/checkpoints are only persisted on disk, if storage param is given. See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/journaldreceiver/README.md Equivalent to filelog change in #567
dmitryax
pushed a commit
that referenced
this pull request
Mar 3, 2023
….source attribute (#681) If `storage: file_storage` param is not configured, the migrated fluentd position file won't be used and cursor won't ever be persisted to disk. Also the Splunk `source` field is currently missing. This is read by the splunkhec exporter from the `com.splunk.source` attribute. See: * https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/filelogreceiver/README.md * https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/splunkhecexporter/README.md * #567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564
storageparameter wasn't configured. So, it wasn't reading the checkpoint at all.