-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/skywalkingreceiver] Add extra link attributes from skywalking ref. #12651
[receiver/skywalkingreceiver] Add extra link attributes from skywalking ref. #12651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinging @liqiangz as code owner
@TylerHelmuth |
You are correct, I accidentally pinged the exporter's owner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see all existing tests are passing, but do any tests need updated because of the new mappings? Is there a tests that exists that should now also be testing that TraceId, ParentTraceSegmentId, and ParentSpanId are mapped correctly?
Adding ready-to-merge since the code owner has also approved. |
Description:
Add more extra information from SkyWalking
ref
to link attributes.(It's the continuation fix after #11562 and this comment. )
Testing: No changes.
Documentation: No changes.