[receiver/skywalking] Fix skywalking traceid and spanid convertion.

[taloric]

Description:

• Backgrounds:

  • Skywalking use segments to cover spans as a group. Also SegmentId + SpanId to identify an unique span in TraceData.
  • Protocols could be found here.
  • The Skywalking receive server handle one segment object in each http request. Those segments have different segmentId and share the same traceId.

• Code Changes:

  • Use a new rule to convert Skywalking-TraceId to Opentelemetry-TraceId. (The old rules breaks relations between segments because it use pointer of strings to generate a new traceId.)
    • Skywalking-TraceId format be like: de5980b8-fce3-4a37-aab9-b4ac3af7eedd(RFC4122) or 56a5e1c519ae4c76a2b8b11d92cead7f.1.16563474296430001.
  • Use SegmentId in the convertion of SpanId to make sure the SpanId is globally unique.
    • SegmentId format be like: 4f2f27748b8e44ecaf18fe0347194e86.33.16560607369950066.
    • The first part of SegmentId(4f2f27748b8e44ecaf18fe0347194e86) will repeat multiple times in a TraceData, so the last part is the real unique identifier of segments.

Testing:

• Add Test_stringToTraceID(): Make sure Skywalking-TraceId convert to the Otel-TraceId by a rule.
• Add Test_segmentIdToSpanId(): Using Skywalking segmentId & spanId to generate a new Otel-SpanId.

Documentation:
No changes.

[taloric]

• Add Jaeger test result here (with otel agent) :
  

• Same application trace in Skywalking dashboard (with skywalking agent) :
  

[codeboten]

Pinging code owner @JaredTan95, please review

[taloric]

@JaredTan95
I found that Skywalking traceid has 2 formats , like de5980b8-fce3-4a37-aab9-b4ac3af7eedd or 56a5e1c519ae4c76a2b8b11d92cead7f.1.16563474296430001 ( Skywalking Live Demo ), but even in protocols I can find no descriptions about that . Wondering if you have any idea of this...

[JaredTan95]

• I found that Skywalking traceid has 2 formats , like de5980b8-fce3-4a37-aab9-b4ac3af7eedd or

de5980b8-fce3-4a37-aab9-b4ac3af7eedd format is produced by the browser/js SDK or envoy/nginx-lua sdk.

[JaredTan95]

• Add Jaeger test result here (with otel agent) :
  
• Same application trace in Skywalking dashboard (with skywalking agent) :
  

hi, @taloric Thanks for the fix, I don't see that your screenshot involves using the skywalking agent to send tracing data to otel collector skywalking receiver and exporter into jaeger. Can you update one?

[taloric]

hi, @taloric Thanks for the fix, I don't see that your screenshot involves using the skywalking agent to send tracing data to otel collector skywalking receiver and exporter into jaeger. Can you update one?

@JaredTan95 Thanks for the review. I did find some bugs during test with skywalking agent. I make some changes about traceid convertion rules.

• Here are my test result (send trace data with skywalking-java-agent)

• They build the same results:

• Jaeger:
  

• skywalking:
  

---

• Also, I make another test with skywalking-python-agent. It brings the same trace tree.
• Jaeger:
  
• skywalking:
  

[JaredTan95]

good catches, LGTM
@taloric BTW, can you change the issue title to [receiver/skywalking] Fix skywalking traceid and spanid convertion. ?

[JaredTan95]

@codeboten PTAL on behalf of approvers.

[taloric]

@codeboten @JaredTan95 @sharang
Refactor the code because there are too much magic numbers which are not understandable. Please take a look.

[JaredTan95]

LGTM
thx for your contributions

[JaredTan95]

@Aneurysm9 PTAL on behalf of approvers.

[taloric]

Skywalking Agent will write skywalking trace info in logs like this:

But after conversion, the relationship between trace and log were lost. So I add skywalking source information in attributes.

@Aneurysm9 @codeboten @JaredTan95 please review.

[JaredTan95]

So I add skywalking source

This is another bug or caused by your pr?

[taloric]

So I add skywalking source

This is another bug or caused by your pr?

It's not caused by this PR. And It's aim to solve the same issue.

I think what our expectation is: application -> Trace data -> otel / skywalking is a full Trace. We can track any step in this Trace with traceid or spanid.

This PR aim to solve Trace broken issues when skywalking traceid convert to otel traceid. (which was done in first commit. ) But that didn't build relations between application Trace logs and otel Trace export result.

So I add skywalking original traceid as attributes to connect application logs with otel export results. Now you can get any skywalking traceid in application logs, and find the same Trace directly in Jaeger or other backends.

@JaredTan95

[JaredTan95]

got it. make sense, LGTM

[taloric]

@codeboten @Aneurysm9 @bogdandrutu would you please take a look at this PR?