[receiver/statsd] Fix metrics with a colon #12124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing formating error
|
@dirceumaranhaopn please sign the CLA |
|
Hi @dmitryax, I have signed. Thx. |
dmitryax
approved these changes
Jul 6, 2022
dmitryax
changed the title
|
@dmitryax would you know why it is failing... I have not change the changelog, and I have added the unreleased yaml file. It seems a false positive. |
|
Hm... I don't know why it's failing. The changelog entry looks good to me. @djaglowski do you know what's the problem here? |
dmitryax
approved these changes
Jul 7, 2022
|
I believe it is failing due to the same reason as #11442. I'll make a PR asap. |
|
I agree the changelog entry looks good. I'll skip the check and merge. |
|
I was unable to reproduce the problem on #12150. Still looking into this. |
|
Thank you @dmitryax and @djaglowski ! |
|
😭 If only we could fix the thing with commas in metric attributes now. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing the bug: #12120
Link to tracking Issue: