Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] check-links fails due to unrelated changes #11442

Closed
djaglowski opened this issue Jun 22, 2022 · 0 comments · Fixed by #11443
Closed

[CI] check-links fails due to unrelated changes #11442

djaglowski opened this issue Jun 22, 2022 · 0 comments · Fixed by #11443
Labels
bug Something isn't working

Comments

@djaglowski
Copy link
Member

djaglowski commented Jun 22, 2022

The check-links job often fails on pull requests due to unrelated changes because it is comparing the branch to origin/main, rather than to a common ancestor with origin/main. This means that changes made on recently merged PRs will be picked up as part of the diff, and therefore validation will run against those files as well. (example)

I believe the solution is to use git merge-base to identify the appropriate common ancestor between origin/main and HEAD.

@djaglowski djaglowski added the bug Something isn't working label Jun 22, 2022
@djaglowski djaglowski changed the title [CI/check-links] [CI] check-links fails due to unrelated changes Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant