Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processors/k8sattributesprocessor: do not ignore hostNetwork pods for enrichment based on non IP attribute(s) #12073

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

newly12
Copy link
Contributor

@newly12 newly12 commented Jul 5, 2022

Description:
processors/k8sattributesprocessor: do not ignore hostNetwork pods for enrichment based on non IP attribute(s). The idea of changes is that if an association rule is using IP based, then hostNetwork pods will be ignored, if the association rule is based on other attributes, then such pods will not be ignored.

Link to tracking Issue:
#10021

Testing:
UT

Documentation:
updated doc.go

@newly12 newly12 requested a review from a team July 5, 2022 06:49
@newly12 newly12 requested review from dmitryax and pmm-sumo as code owners July 5, 2022 06:49
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing this!

@dmitryax dmitryax merged commit e79d917 into open-telemetry:main Jul 5, 2022
@newly12 newly12 deleted the host_network_pod branch July 6, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants