Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8sattributesprocessor should not ignore hostNetwork pods for enrichment based on non IP attribute(s) #10021

Closed
newly12 opened this issue May 14, 2022 · 0 comments

Comments

@newly12
Copy link
Contributor

newly12 commented May 14, 2022

Is your feature request related to a problem? Please describe.
enrichment will skipped for pods running in host network mode, this may be true if based on pod IP, but not the case if based on other attributes e.g. pod_uid, or a combination of multiple attributes is being addressed by #8465
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.51.0/processor/k8sattributesprocessor/internal/kube/client.go#L438-L446

Describe the solution you'd like
host network pods should only be ignored if the enrichment is based on pod IP.

Describe alternatives you've considered
Option to not ignore host network pods.

Additional context

@newly12 newly12 changed the title k8sattributesprocessor do not ignore hostNetwork pods for enrichment based on non IP attribute(s) k8sattributesprocessor should not ignore hostNetwork pods for enrichment based on non IP attribute(s) May 14, 2022
@newly12 newly12 closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant