Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing github.com/tilinna/clock to with a more maintained library #34190

Closed
ChrsMark opened this issue Jul 22, 2024 · 5 comments
Closed

Consider replacing github.com/tilinna/clock to with a more maintained library #34190

ChrsMark opened this issue Jul 22, 2024 · 5 comments
Assignees
@odubajDT
Labels
connector/spanmetrics enhancement New feature or request extension/jaegerremotesampling receiver/chrony

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Jul 22, 2024 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

https://github.com/tilinna/clock is used in several places in the project:

/extension/jaegerremotesampling/internal/remote_strategy_cache.go
./extension/jaegerremotesampling/internal/remote_strategy_cache_test.go
./receiver/chronyreceiver/internal/chrony/client.go
./receiver/chronyreceiver/scraper_test.go
./receiver/chronyreceiver/scraper.go
./connector/spanmetricsconnector/factory.go
./connector/spanmetricsconnector/connector.go
./connector/spanmetricsconnector/connector_test.go

However at #34128 (comment) it was proposed to switch to another similar library which is better maintained. The proposed library is https://github.com/jonboulle/clockwork and is already tried at #34128 and #34174.

https://github.com/jonboulle/clockwork has notably more contributors and counts quite a few usages by other projects/repositories.

Based on this, the current issue proposes to gradually start switching from https://github.com/tilinna/clock to https://github.com/jonboulle/clockwork.

/cc @djaglowski @pjanotti
@ChrsMark ChrsMark added the needs triage New item requiring triage label Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for connector/spanmetrics: @portertech @Frapschen. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for extension/jaegerremotesampling: @yurishkuro @frzifus. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/chrony: @MovieStoreGuy @jamesmoessis. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added enhancement New feature or request and removed needs triage New item requiring triage labels Jul 22, 2024
@github-actions github-actions bot mentioned this issue Jul 23, 2024
Closed
@odubajDT
Copy link
Contributor

Hi, if possible I would like to pick up this issue

This was referenced Jul 23, 2024
Merged
Merged
Merged
djaglowski pushed a commit that referenced this issue Jul 23, 2024
@odubajDT
[chore][extensions/jaegerremotesampling]: replace `github.com/tilinna…
5d772df 
…/clock` with `github.com/jonboulle/clockwork` (#34224)

**Description:**
- replaces `github.com/tilinna/clock` with
`github.com/jonboulle/clockwork` in `jaegerremotesampleing extension`

**Link to tracking Issue:**
#34190

**Connected PRs:**
-
#34221
-
#34226

---------

Signed-off-by: odubajDT <[email protected]>
djaglowski pushed a commit that referenced this issue Jul 23, 2024
@odubajDT
[chore][receiver/chrony]: replace github.com/tilinna/clock with `gi…
5f7025a 
…thub.com/jonboulle/clockwork` (#34221)

**Description:**
- replaces `github.com/tilinna/clock` with
`github.com/jonboulle/clockwork` in `chrony receiver`

**Link to tracking Issue:**
#34190

**Connected PRs:**
-
#34224
-
#34226

**Notes:**

The failing check is not caused by changes in this PR, it's a flaky test
#33865

---------

Signed-off-by: odubajDT <[email protected]>
djaglowski pushed a commit that referenced this issue Jul 24, 2024
@odubajDT
[chore][connector/spanmetrics]: replace github.com/tilinna/clock wi…
d5c40d3 
…th `github.com/jonboulle/clockwork` (#34226)

**Description:**
- replaces `github.com/tilinna/clock` with
`github.com/jonboulle/clockwork` in `spanmetrics connector`

**Link to tracking Issue:**
#34190

**Connected PRs:**
-
#34221
-
#34224

---------

Signed-off-by: odubajDT <[email protected]>
@djaglowski
Copy link
Member

Closed by #34221 #34224 #34226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odubajDT odubajDT

Labels
connector/spanmetrics enhancement New feature or request extension/jaegerremotesampling receiver/chrony
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@djaglowski @ChrsMark @crobert-1 @odubajDT