-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Decouple global span attributes from RumAttributeAppender (#375)
* Decouple global span attributes from RumAttributeAppender * Moved OTel stuff to io.opentelemetry.rum.internal
- Loading branch information
Mateusz Rzeszutek
authored
Oct 12, 2022
1 parent
9bef49c
commit b3e540e
Showing
10 changed files
with
204 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
...tel-android/src/main/java/io/opentelemetry/rum/internal/GlobalAttributesSpanAppender.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /* | ||
| * Copyright Splunk Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.opentelemetry.rum.internal; | ||
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| import io.opentelemetry.api.common.Attributes; | ||
| import io.opentelemetry.api.common.AttributesBuilder; | ||
| import io.opentelemetry.context.Context; | ||
| import io.opentelemetry.sdk.trace.ReadWriteSpan; | ||
| import io.opentelemetry.sdk.trace.ReadableSpan; | ||
| import io.opentelemetry.sdk.trace.SpanProcessor; | ||
| import java.util.concurrent.atomic.AtomicReference; | ||
| import java.util.function.Consumer; | ||
|
|
||
| /** | ||
| * A {@link SpanProcessor} implementation that appends a set of {@linkplain Attributes attributes} | ||
| * to every span that is exported. The attributes collection is mutable, and can be updated by | ||
| * calling {@link #update(Consumer)}. | ||
| * | ||
| * <p>This class is internal and is hence not for public use. Its APIs are unstable and can change | ||
| * at any time. | ||
| */ | ||
| public final class GlobalAttributesSpanAppender implements SpanProcessor { | ||
|
|
||
| /** | ||
| * Returns a new {@link GlobalAttributesSpanAppender} with a given initial attributes. | ||
| * | ||
| * @param initialState The initial collection of attributes to append to every span. | ||
| */ | ||
| public static GlobalAttributesSpanAppender create(Attributes initialState) { | ||
| return new GlobalAttributesSpanAppender(initialState); | ||
| } | ||
|
|
||
| private final AtomicReference<Attributes> attributes; | ||
|
|
||
| private GlobalAttributesSpanAppender(Attributes initialState) { | ||
| this.attributes = new AtomicReference<>(initialState); | ||
| } | ||
|
|
||
| @Override | ||
| public void onStart(Context parentContext, ReadWriteSpan span) { | ||
| span.setAllAttributes(attributes.get()); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isStartRequired() { | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public void onEnd(ReadableSpan span) {} | ||
|
|
||
| @Override | ||
| public boolean isEndRequired() { | ||
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * Update the global set of attributes that will be appended to every span. | ||
| * | ||
| * <p>Note: this operation performs an atomic update. The passed function should be free from | ||
| * side effects, since it may be called multiple times in case of thread contention. | ||
| * | ||
| * @param attributesUpdater A function which will update the current set of attributes, by | ||
| * operating on a {@link AttributesBuilder} from the current set. | ||
| */ | ||
| public void update(Consumer<AttributesBuilder> attributesUpdater) { | ||
| while (true) { | ||
| // we're absolutely certain this will never be null | ||
| Attributes oldAttributes = requireNonNull(attributes.get()); | ||
|
|
||
| AttributesBuilder builder = oldAttributes.toBuilder(); | ||
| attributesUpdater.accept(builder); | ||
| Attributes newAttributes = builder.build(); | ||
|
|
||
| if (attributes.compareAndSet(oldAttributes, newAttributes)) { | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.