Skip to content

Commit

Permalink
Minor API fix (#377)
Browse files Browse the repository at this point in the history
  • Loading branch information
Mateusz Rzeszutek authored Oct 11, 2022
1 parent d859a9d commit 9bef49c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
22 changes: 11 additions & 11 deletions splunk-otel-android/src/main/java/com/splunk/rum/SplunkRum.java
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,17 @@ public static SplunkRum getInstance() {
return INSTANCE;
}

/**
* Initialize a no-op version of the SplunkRum API, including the instance of OpenTelemetry that
* is available. This can be useful for testing, or configuring your app without RUM enabled,
* but still using the APIs.
*
* @return A no-op instance of {@link SplunkRum}
*/
public static SplunkRum noop() {
return NoOpSplunkRum.INSTANCE;
}

/**
* Wrap the provided {@link OkHttpClient} with OpenTelemetry and RUM instrumentation. Since
* {@link Call.Factory} is the primary useful interface implemented by the OkHttpClient, this
Expand Down Expand Up @@ -310,17 +321,6 @@ void flushSpans() {
openTelemetrySdk.getSdkTracerProvider().forceFlush().join(1, TimeUnit.SECONDS);
}

/**
* Initialize a no-op version of the SplunkRum API, including the instance of OpenTelemetry that
* is available. This can be useful for testing, or configuring your app without RUM enabled,
* but still using the APIs.
*
* @return A no-op instance of {@link SplunkRum}
*/
public static SplunkRum noop() {
return NoOpSplunkRum.INSTANCE;
}

/**
* This method will enable Splunk Browser-based RUM to integrate with the current Android RUM
* Session. It injects a javascript object named "SplunkRumNative" into your WebView which
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public SplunkRumBuilder disableCrashReporting() {
*
* @return {@code this}
*/
public SplunkRumBuilder disableNetworkMonitorEnabled() {
public SplunkRumBuilder disableNetworkMonitor() {
this.networkMonitorEnabled = false;
return this;
}
Expand Down

0 comments on commit 9bef49c

Please sign in to comment.