Add ability to indicate Capabilities in the protocol #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves open-telemetry#7 Resolves open-telemetry#25 This change clarifies how the protocols should work when a particular capability is not supported. It also defines how future extensions for the protocol capabilities will work.
djaglowski
reviewed
Nov 17, 2021
djaglowski
reviewed
Nov 17, 2021
djaglowski
approved these changes
Nov 17, 2021
|
@pmm-sumo I think you raised this question. Please see if this PR answers it. |
pmm-sumo
reviewed
Nov 18, 2021
pmm-sumo
approved these changes
Nov 18, 2021
|
Let's merge this. We may need to tweak the capabilities when we do the actual implementation. The prototyping will help clarify the edge cases when the information about capabilities is necessary. |
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Dec 1, 2021
Corresponds to spec change: open-telemetry/opamp-spec#33 Future PRs will add the logic to use the capabilities.
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Dec 2, 2021
Corresponds to spec change: open-telemetry/opamp-spec#33 Future PRs will add the logic to use the capabilities.
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
Dec 3, 2021
Corresponds to spec change: open-telemetry/opamp-spec#33 Future PRs will add the logic to use the capabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7
Resolves #25
This change clarifies how the protocols should work when a particular
capability is not supported. It also defines how future extensions
for the protocol capabilities will work.