Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how the protocols should work when a particular capability is not supported #7

Closed
tigrannajaryan opened this issue Nov 9, 2021 · 0 comments · Fixed by #33
Closed

Clarify how the protocols should work when a particular capability is not supported #7

tigrannajaryan opened this issue Nov 9, 2021 · 0 comments · Fixed by #33

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Nov 9, 2021 •
edited
Loading

The spec does not tell how the protocol works when the client or the serve don't support a particular capability (e.g. addons are not supported).

Need to clarify it.

This is also related to how we plan to support addition of new features to the protocol in the future. It may be that we can use the same capability signalling mechanism to express that fact that a particular feature is not supported by the peer, including features that are currently already in the spec or the features that we may add to the spec in the future.
This was referenced Nov 9, 2021
Merged
Closed
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Nov 17, 2021
@tigrannajaryan
Add ability to indicate Capabilities in the protocol
ef9db7d 
Resolves open-telemetry#7
Resolves open-telemetry#25

This change clarifies how the protocols should work when a particular
capability is not supported. It also defines how future extensions
for the protocol capabilities will work.
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Nov 17, 2021
@tigrannajaryan
Add ability to indicate Capabilities in the protocol
a4bceb3 
Resolves open-telemetry#7
Resolves open-telemetry#25

This change clarifies how the protocols should work when a particular
capability is not supported. It also defines how future extensions
for the protocol capabilities will work.
@tigrannajaryan tigrannajaryan mentioned this issue Nov 17, 2021
Merged
tigrannajaryan added a commit that referenced this issue Nov 18, 2021
@tigrannajaryan
Add ability to indicate Capabilities in the protocol (#33)
75f6c50 
Resolves #7
Resolves #25

This change clarifies how the protocols should work when a particular
capability is not supported. It also defines how future extensions
for the protocol capabilities will work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to indicate Capabilities in the protocol tigrannajaryan/opamp-spec
1 participant
@tigrannajaryan