-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting Headers in DownloadableFile message #197
Allow setting Headers in DownloadableFile message #197
Conversation
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tpaschalis
LGTM. Once merged let's add corresponding implementation in OpAMP Go.
@andykellr I will keep this open for a couple days in case you have any comments.
Yes, I can handle that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I missed is that we want all new additions to start in [Development] status.
@@ -2343,7 +2344,9 @@ should download the file: | |||
and the file SHOULD be downloaded from the location specified in the | |||
[download_url](#downloadablefiledownload_url) field of the | |||
[DownloadableFile](#downloadablefile-message) message. The Agent SHOULD use an | |||
HTTP GET message to download the file. | |||
HTTP GET message to download the file. The Agent SHOULD include the HTTP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mark this addition as [Development]
. See how it's done in other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for missing that 🤦
Done, both in the proto definition, and in specification (both inline to the message and in the separate section).
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@tpaschalis thank you for adding this feature. |
Fixes #194
This PR amends the spec and protos to include an optional set of headers in DownloadableFile, to be used in the download GET request to set up auth parameters.
This is only one of the ways we could implement setting authentication paramaters to be used by Agents when downloading packages, but it is consistent with other uses of the headers field and generic enough to cover different use cases so I feel it's worth considering.