Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting authentication in DownloadableFile message #194

Closed
tpaschalis opened this issue Jun 28, 2024 · 1 comment · Fixed by #197
Closed

Allow setting authentication in DownloadableFile message #194

tpaschalis opened this issue Jun 28, 2024 · 1 comment · Fixed by #197

Comments

@tpaschalis
Copy link
Member

tpaschalis commented Jun 28, 2024

This issue is spurred by a discussion in open-telemetry/opamp-go#196.

In some cases, it might be useful to have the server include authentication parameters along the DownloadableFile in one way or the other.

Proposal

The proposed way is to add a new headers Headers field, so that can happen via Authentication headers and provide some flexibility into what authentication method is actually used.

Alternatives considered

One alternative considered would be to accept a userinfo section in the download_url (like http://username:[email protected]/), but that is only good for Basic Auth so it locks us out of using alternative authentication methods, while some newer HTTP Semantic RFC9110 advocate for its deprecation so if might not be the best long-term solution

@tpaschalis tpaschalis changed the title Allow setting authentication DownloadableFilex Allow setting authentication DownloadableFile message Jun 28, 2024
@tpaschalis tpaschalis changed the title Allow setting authentication DownloadableFile message Allow setting authentication in DownloadableFile message Jun 28, 2024
@tpaschalis
Copy link
Member Author

I also meant to cc @phanidevavarapu who opened the original issue on the opam-go repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant