Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark certain capabilities as Beta #147

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Jun 15, 2023

Contributes to #146

As agreed we will mark certain capabilities as Beta for now, until we have more confidence that they are well-specified. This will be primarily driven by feedback from implementations.

Capabilities marked Beta:

  • Packages
  • Connection Settings Managements
  • Own Telemetry Reporting
  • Server to Agent Command.

@tigrannajaryan
Copy link
Member Author

@andykellr please take a look.

@tigrannajaryan tigrannajaryan requested a review from andykellr June 27, 2023 14:59
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question about OwnTelemetry status inconsistency. LGTM otherwise!

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/statuslabels branch from 19f64d7 to 2677217 Compare June 28, 2023 03:24
Contributes to open-telemetry#146

As agreed we will mark certain capabilities as Beta for now,
until we have more confidence that they are well-specified.
This will be primarily driven by feedback from implementations.

Capabilities marked Beta:
- Packages
- Connection Settings Managements
- Own Telemetry Reporting
- Server to Agent Command.
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/statuslabels branch from 2677217 to 6c018e0 Compare July 6, 2023 13:43
@tigrannajaryan
Copy link
Member Author

I added "Server to Agent Command" to the beta list.

@tigrannajaryan tigrannajaryan marked this pull request as ready for review July 6, 2023 13:44
@tigrannajaryan tigrannajaryan requested a review from a team July 6, 2023 13:44
@tigrannajaryan
Copy link
Member Author

@andykellr please take a look.

Copy link
Contributor

@andykellr andykellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these designations, but BindPlane is using the various Package messages and it is working well. I would be ok removing Beta from those capabilities.

@tigrannajaryan
Copy link
Member Author

BindPlane is using the various Package messages and it is working well. I would be ok removing Beta from those capabilities.

I agree. I also played with it in my private repo and it worked well. However, I would still want to see at least an official example in opamp-go before we remove the "beta" label. I think this should be the minimum bar we need to clear for every capability.

@tigrannajaryan tigrannajaryan merged commit 67a5580 into open-telemetry:main Jul 6, 2023
@tigrannajaryan tigrannajaryan deleted the feature/tigran/statuslabels branch July 6, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants