Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare stability per capability or for all spec? #146

Closed
tigrannajaryan opened this issue Jun 13, 2023 · 5 comments
Closed

Declare stability per capability or for all spec? #146

tigrannajaryan opened this issue Jun 13, 2023 · 5 comments
Assignees
@tigrannajaryan
Labels
required-for-stable Required to be resolved before 1.0

Comments

@tigrannajaryan
Copy link
Member

We discussed that we want to wait for some OpAMP implementations to complete before we declare the spec stable, so that there is time to learn from the implementations and adjust the spec if needed. However the implementations that are in progress don't utilize all OpAMP capabilities, so we can't expect to learn much about these areas.

Should we declare stability of the spec for the capabilities that we know are relatively well-tested and move the other capabilities to a separate section and mark as "Beta" addition to the spec for now?

The spec sections and capabilities I am less confident about and which I think are not used in any implementations so far are:

We can probably mark these sections as [Beta] and the rest of the sections can be declared Stable.

@open-telemetry/opamp-spec-approvers what do you think?
@andykellr
Copy link
Contributor

I think that makes sense. BindPlane does use Packages and PackageStatuses for agent upgrade and it was worked well. It does not currently use ConnectionSettings.

@tigrannajaryan
Copy link
Member Author

I think that makes sense. BindPlane does use Packages and PackageStatuses for agent upgrade and it was worked well. It does not currently use ConnectionSettings.

@andykellr are there any other capabilities that BindPlane does not use? Do you utilize everything except Connection Settings?

@andykellr
Copy link
Contributor

I think that makes sense. BindPlane does use Packages and PackageStatuses for agent upgrade and it was worked well. It does not currently use ConnectionSettings.

@andykellr are there any other capabilities that BindPlane does not use? Do you utilize everything except Connection Settings?

ConnectionSettings and AgentIdentification are not currently used by BindPlane.

@tigrannajaryan
Copy link
Member Author

Discussed in workgroup meeting today and decided that it is reasonable to declare only portions of the spec stable and keep less-tested parts as beta. I will work on figuring out the exact labeling mechanism.

@tigrannajaryan tigrannajaryan self-assigned this Jun 13, 2023
@tigrannajaryan tigrannajaryan added the required-for-stable Required to be resolved before 1.0 label Jun 13, 2023
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Jun 15, 2023
@tigrannajaryan
Mark certain capabilities as Beta
95d505b 
Contribures open-telemetry#146

As agreed we will mark certain capabilities as Beta for now,
until we have more confidence that they are well-specified.
This will be primarily driven by feedback from implementations.
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Jun 15, 2023
@tigrannajaryan
Mark certain capabilities as Beta
8860afb 
Contribures open-telemetry#146

As agreed we will mark certain capabilities as Beta for now,
until we have more confidence that they are well-specified.
This will be primarily driven by feedback from implementations.

Capabilities marked Beta:
- Packages
- Connection Settings Managements
- Own Telemetry Reporting
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Jun 15, 2023
@tigrannajaryan
Mark certain capabilities as Beta
19f64d7 
Contributes to open-telemetry#146

As agreed we will mark certain capabilities as Beta for now,
until we have more confidence that they are well-specified.
This will be primarily driven by feedback from implementations.

Capabilities marked Beta:
- Packages
- Connection Settings Managements
- Own Telemetry Reporting
@tigrannajaryan tigrannajaryan mentioned this issue Jun 15, 2023
Merged
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Jun 28, 2023
@tigrannajaryan
Mark certain capabilities as Beta
2677217 
Contributes to open-telemetry#146

As agreed we will mark certain capabilities as Beta for now,
until we have more confidence that they are well-specified.
This will be primarily driven by feedback from implementations.

Capabilities marked Beta:
- Packages
- Connection Settings Managements
- Own Telemetry Reporting
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Jul 6, 2023
@tigrannajaryan
Mark certain capabilities as Beta
6c018e0 
Contributes to open-telemetry#146

As agreed we will mark certain capabilities as Beta for now,
until we have more confidence that they are well-specified.
This will be primarily driven by feedback from implementations.

Capabilities marked Beta:
- Packages
- Connection Settings Managements
- Own Telemetry Reporting
- Server to Agent Command.
tigrannajaryan added a commit that referenced this issue Jul 6, 2023
@tigrannajaryan
Mark certain capabilities as Beta (#147)
67a5580 
Contributes to #146

As agreed we will mark certain capabilities as Beta for now,
until we have more confidence that they are well-specified.
This will be primarily driven by feedback from implementations.

Capabilities marked Beta:
- Packages
- Connection Settings Managements
- Own Telemetry Reporting
- Server to Agent Command.
@tigrannajaryan
Copy link
Member Author

Done in #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
required-for-stable Required to be resolved before 1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andykellr @tigrannajaryan