Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReportsRemoteConfig capability #112

Closed
tigrannajaryan opened this issue Jul 22, 2022 · 2 comments · Fixed by #115
Closed

Add ReportsRemoteConfig capability #112

tigrannajaryan opened this issue Jul 22, 2022 · 2 comments · Fixed by #115
Labels
required-for-stable Required to be resolved before 1.0

Comments

@tigrannajaryan
Copy link
Member

All reporting capabilities currently are individually represented as a bit in the Capabilities field, export the capability to report remote config. I think we need to add this bit too.
@tigrannajaryan
Copy link
Member Author

I think this should be also resolved before 1.0.

@tigrannajaryan tigrannajaryan added the required-for-stable Required to be resolved before 1.0 label Jul 26, 2022
@tigrannajaryan
Copy link
Member Author

@andykellr what do you think?

tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Jul 28, 2022
@tigrannajaryan
Add ReportsRemoteConfig capability
3a9f26d 
Resolves open-telemetry#112

All other status fields have a corresponding capability bit except this
one. This results in a non-consistent looking implementation that
has to rely on AcceptsRemoteConfig bit instead to figure out if
RemoteConfigStatus reporting is expected, for example:
https://github.com/open-telemetry/opamp-go/pull/105/files#diff-620a7a2b42e4a4c60a590b0cca50053006e4555c6e70f38dece2f3a6d7ed1338R214

Adding this bit makes the status fields and their corresponding
capabilities bits consistent.
@tigrannajaryan tigrannajaryan mentioned this issue Jul 28, 2022
Merged
tigrannajaryan added a commit that referenced this issue Jul 28, 2022
@tigrannajaryan
Add ReportsRemoteConfig capability (#115)
cec6d2e 
Resolves #112

All other status fields have a corresponding capability bit except this
one. This results in a non-consistent looking implementation that
has to rely on AcceptsRemoteConfig bit instead to figure out if
RemoteConfigStatus reporting is expected, for example:
https://github.com/open-telemetry/opamp-go/pull/105/files#diff-620a7a2b42e4a4c60a590b0cca50053006e4555c6e70f38dece2f3a6d7ed1338R214

Adding this bit makes the status fields and their corresponding
capabilities bits consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
required-for-stable Required to be resolved before 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ReportsRemoteConfig capability tigrannajaryan/opamp-spec
1 participant
@tigrannajaryan