Add ReportsRemoteConfig capability #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves open-telemetry#112 All other status fields have a corresponding capability bit except this one. This results in a non-consistent looking implementation that has to rely on AcceptsRemoteConfig bit instead to figure out if RemoteConfigStatus reporting is expected, for example: https://github.com/open-telemetry/opamp-go/pull/105/files#diff-620a7a2b42e4a4c60a590b0cca50053006e4555c6e70f38dece2f3a6d7ed1338R214 Adding this bit makes the status fields and their corresponding capabilities bits consistent.
tigrannajaryan
force-pushed
the
feature/tigran/add-reportsremoteconfig
branch
from
7f22cb4 to
3a9f26d
Compare
andykellr
approved these changes
Jul 28, 2022
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Jul 28, 2022
Implements spec change open-telemetry/opamp-spec#115
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
Aug 15, 2022
Implements spec change open-telemetry/opamp-spec#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ReportsRemoteConfig capability
Resolves #112
All other status fields have a corresponding capability bit except this
one. This results in a non-consistent looking implementation that
has to rely on AcceptsRemoteConfig bit instead to figure out if
RemoteConfigStatus reporting is expected, for example:
https://github.com/open-telemetry/opamp-go/pull/105/files#diff-620a7a2b42e4a4c60a590b0cca50053006e4555c6e70f38dece2f3a6d7ed1338R214
Adding this bit makes the status fields and their corresponding
capabilities bits consistent.