Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReportsRemoteConfig capability #114

Conversation

tigrannajaryan
Copy link
Member

Implements spec change open-telemetry/opamp-spec#115

@tigrannajaryan tigrannajaryan requested a review from a team July 28, 2022 19:07
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #114 (6f10b4c) into main (3d4cbdc) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   74.89%   74.75%   -0.14%     
==========================================
  Files          22       22              
  Lines        1629     1632       +3     
==========================================
  Hits         1220     1220              
- Misses        307      309       +2     
- Partials      102      103       +1     
Impacted Files Coverage Δ
client/internal/clientcommon.go 78.32% <0.00%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4cbdc...6f10b4c. Read the comment docs.

@tigrannajaryan
Copy link
Member Author

@andykellr please review.

@tigrannajaryan tigrannajaryan merged commit 0c1d2c1 into open-telemetry:main Aug 15, 2022
@tigrannajaryan tigrannajaryan deleted the feature/tigran/add-reportsremoteconfig branch August 15, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants