Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore reviews before rephrase #667

Merged
merged 3 commits into from
Jul 14, 2024

Conversation

Luc-Mcgrady
Copy link
Member

@Luc-Mcgrady Luc-Mcgrady commented Jul 13, 2024

#659

If there's anything I'm missing let me know.

@brishtibheja
Copy link

Can we remove the word Evaluate from there? As @user1823 explained, Evaluate behaves the same way scheduler does.

Now, I don't think it is necessary to explain how the scheduler is working or the evaluation unless it would create confusion among users. @Expertium If you have something to say.

brishtibheja added a commit to brishtibheja/anki that referenced this pull request Jul 14, 2024
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock L-M-Sherlock added this pull request to the merge queue Jul 14, 2024
Merged via the queue into open-spaced-repetition:main with commit 3e80035 Jul 14, 2024
dae pushed a commit to ankitects/anki that referenced this pull request Jul 21, 2024
* Update Tooltip

updated the tooltips as described here: https://forums.ankiweb.net/t/update-tooltips/46849

* Update CONTRIBUTORS

* Update deck-config.ftl

* fixed punctuation, stylistic incoherence, etc.

* Update deck-config.ftl

open-spaced-repetition/fsrs4anki#667

* Changed string requires new key (dae)

* Minor tweaks to tense for clarity (dae)

#3288 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants