Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tooltip #3288

Merged
merged 9 commits into from
Jul 21, 2024
Merged

Update Tooltip #3288

merged 9 commits into from
Jul 21, 2024

Conversation

brishtibheja
Copy link
Contributor

updated the tooltips as described here: https://forums.ankiweb.net/t/update-tooltips/46849

@dae
Copy link
Member

dae commented Jul 10, 2024

Thank you for contributing!

Because the meaning has changed and we want the translators to update the strings too, we need to leave the existing ones alone, and add new ones with a -2 suffix, then update the code to point to the new strings. Please also update the CONTRIBUTORS file so that automatic tests pass.

@brishtibheja
Copy link
Contributor Author

brishtibheja commented Jul 10, 2024

add new ones with a -2 suffix

I did but one of them already had a -2 suffix. I left it as it is. I added the previous strings to the end of the file. If you need to change something, please do it.

I was a bit confused what to do here as I saw tooltip2 and tool-tip-2 at places and some tooltip-2 didn't have the equivalent tooltip.

@Expertium
Copy link
Contributor

Continuing the conversation I had with Sorata in Discord, deck-config-historical-retention-tooltip should be changed. It makes it sound like review history is permanently deleted when "Ignore reviews before" is used, which is not true. It's just omitted.

user1823 added a commit to user1823/anki that referenced this pull request Jul 13, 2024
user1823 added a commit to user1823/anki that referenced this pull request Jul 21, 2024
@dae dae merged commit 087f957 into ankitects:main Jul 21, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants