-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/ssp-move-algorithm-to-DefaultExperiment #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for leaving this hanging for so long. Mostly good, just some small change requests from my side. Also, I'd like a second opinion on the XSD change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the Jenkins build (can be fixed by merging master into this) things look good from my point of view.
How about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
I'd like to get a verdict on |
If there is no objections by the end of the day I'll merge using |
I agree, |
This PR moves the osp runtime annotation stuff inside DefaultExperiment where it belongs.
This also reduces the complexity of
ssp_parser.cpp
I have also renamed
osp:SimulationInformation
toosp:Algorithm
and removed the description tag.osp:FixedStepMaster
is renamed toosp:FixedStepAlgorithm
Old:
New:
It also adds a
xsd
.