-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSP] Move and rename osp algorithm annotation into DefaultExperiment & make algorithms pluggable #426
Conversation
Side note: <osp:Algorithm>
<osp:FixedStepAlgorithm stepSize="1e-4"/>
</osp:Algorithm> Is that it is extensible and allows custom properties for each Algorithm. The new |
I like this! Not only the XML change, but also that it combines the |
I have added a plugin based system for parsing algorithms, modelled after the |
This is a first draft. I want feedback. E.g. this API requires the user to pass a default |
Preferably I think auto ssp_loader = cse::ssp_loader();
ssp_loader .set_override_algorithm = ...
ssp_loader .load(xmlPath);
|
This PR is a huge improvement to the code base.
But some cleanup/moving of files is surely needed. |
Added support for multiple-step-sizes with the help of #439 |
Personally, I'd prefer it if they were two separate PRs. The latest "plugability" change seems to be independent of the XML change, and at least in my mind, it's quite a bit more controversial.
That's actually not a bad alternative. The second PR can always be retargeted on |
I can make it into two separate PRs tomorrow. |
This PR moves the osp runtime annotation stuff inside DefaultExperiment where it belongs.
This also reduces the complexity of
ssp_parser.cpp
I have also renamed
osp:SimulationInformation
toosp:Algorithm
and removed the description tag.osp:FixedStepMaster
is renamed toosp:FixedStepAlgorithm
Old:
New:
This PR might be hard to swallow since it is non backwards compatible. But IMO it is a great improvement.
Closes #435
Closes #437