Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

feat: add million.js #487

Merged
merged 1 commit into from
Sep 6, 2023
Merged

feat: add million.js #487

merged 1 commit into from
Sep 6, 2023

Conversation

ayusham001
Copy link
Contributor

@ayusham001 ayusham001 commented Sep 6, 2023 •
edited by brandonroberts
Loading

@netlify
Copy link

netlify bot commented Sep 6, 2023 •
edited
Loading

✅ Deploy Preview for hot-sauced-ui ready!

Name Link
🔨 Latest commit dd1316c
🔍 Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/64f8665284a476000867f94d
😎 Deploy Preview https://deploy-preview-487--hot-sauced-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Sep 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • npm-shrinkwrap.json
  • package.json

github-actions[bot]
github-actions bot reviewed Sep 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@ayusham001 ayusham001 mentioned this pull request Sep 6, 2023
Closed
2 tasks
@ayusham001
Copy link
Contributor Author

Hi @brandonroberts Please review my PR

@ayusham001 ayusham001 changed the title feat: add million.js Feature: Integrate million.js Sep 6, 2023
@ayusham001 ayusham001 changed the title Feature: Integrate million.js Feat: add million.js Sep 6, 2023
@ayusham001 ayusham001 changed the title Feat: add million.js feat: add million.js Sep 6, 2023
@brandonroberts brandonroberts requested review from bdougie, a team, a0m0rajab and NsdHSO and removed request for a team September 6, 2023 13:30
@bdougie
Copy link
Member

bdougie commented Sep 6, 2023

Really weird that lighthouse doesn't even run in production, but happy see the benfits of this PR.

Screen Shot 2023-09-06 at 7 38 43 AM

@bdougie bdougie requested a review from a team September 6, 2023 15:43
@a0m0rajab
Copy link

This is a lighthouse image from the main website:
image

a0m0rajab
a0m0rajab approved these changes Sep 6, 2023
View reviewed changes
Copy link

@a0m0rajab a0m0rajab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the business decision side, but this seems to have a great impact and easy adoption based on the docs they have.

@bdougie
Copy link
Member

bdougie commented Sep 6, 2023

I am not sure about the business decision side, but this seems to have a great impact and easy adoption based on the docs they have.

going to merge it. This project is a good place to test it out and doesn't effect any business decisions. Overall I'd love to see if we can revive this project.

@bdougie bdougie merged commit b8acfb8 into open-sauced:beta Sep 6, 2023
@a0m0rajab
Copy link

By revive do you mean as users or as contributors?

github-actions bot pushed a commit that referenced this pull request Sep 6, 2023
@ayusham001 @open-sauced
chore(minor): release 2.34.0-beta.1 on beta channel [skip ci]
5e37df8 
## [2.34.0-beta.1](v2.33.2-beta.2...v2.34.0-beta.1) (2023-09-06)

### 🍕 Features

* add million.js ([#487](#487)) ([b8acfb8](b8acfb8))
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🎉 This PR is included in version 2.34.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ayusham001
Copy link
Contributor Author

Thank you. @bdougie

@bdougie bdougie mentioned this pull request Sep 6, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 6, 2023
@bdougie @open-sauced
chore(minor): release 2.34.0 [skip ci]
49c3c13 
## [2.34.0](v2.33.1...v2.34.0) (2023-09-06)

### 🐛 Bug Fixes

* fixed nav menu button ([#483](#483)) ([dba7890](dba7890))
* update repo to open-sauced/app ([#485](#485)) ([0fd1f73](0fd1f73))

### 🍕 Features

* add million.js ([#487](#487)) ([b8acfb8](b8acfb8))
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🎉 This PR is included in version 2.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@a0m0rajab a0m0rajab a0m0rajab approved these changes

@bdougie bdougie bdougie approved these changes

@NsdHSO NsdHSO Awaiting requested review from NsdHSO

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Integrate million.js
3 participants
@ayusham001 @bdougie @a0m0rajab