This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
fix: fixed nav menu button #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
looks like #477 has to be fixed before this can be tested |
takanome-dev
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
It works 👍
nit: @dev-phantom Can you run npm run format and push again to revert unrelated changes?
i ran it before there are currently no lint issues |
|
Can you add a before/after screenshot? |
I can't Because of this issue #477 |
|
cc @bdougie Before hamburger-btn-before.mp4After hamburger-btn-after.mp4 |
bdougie
approved these changes
Aug 22, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
## [2.33.2-beta.1](v2.33.1...v2.33.2-beta.1) (2023-08-22) ### 🐛 Bug Fixes * fixed nav menu button ([#483](#483)) ([dba7890](dba7890))
|
🎉 This PR is included in version 2.33.2-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed the nav button that was not displaying the nav menu
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #482
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?